Skip to content

CI: Push nighthawk-benchmark images#640

Merged
mum4k merged 1 commit intoenvoyproxy:mainfrom
oschaaf:ci-push-benchmark-dev
Mar 9, 2021
Merged

CI: Push nighthawk-benchmark images#640
mum4k merged 1 commit intoenvoyproxy:mainfrom
oschaaf:ci-push-benchmark-dev

Conversation

@oschaaf
Copy link
Copy Markdown
Member

@oschaaf oschaaf commented Mar 8, 2021

Thanks to @mklein for helping out with the dockerhub namespaces.

Fixes #611

Signed-off-by: Otto van der Schaaf ovanders@redhat.com

Thanks to @mklein for helping out with the dockerhub namespaces.

Fixes envoyproxy#611

Signed-off-by: Otto van der Schaaf <ovanders@redhat.com>
@oschaaf oschaaf added the waiting-for-review A PR waiting for a review. label Mar 8, 2021
@oschaaf oschaaf requested a review from abaptiste March 8, 2021 11:34
Copy link
Copy Markdown
Contributor

@abaptiste abaptiste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @oschaaf.

@mum4k
Copy link
Copy Markdown
Collaborator

mum4k commented Mar 9, 2021

@oschaaf how are permissions when it comes to writing to these namespaces configured, do you know?

@mum4k mum4k merged commit e2f5265 into envoyproxy:main Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-for-review A PR waiting for a review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consolidate a proper location for pushing benchmark docker images from CI

3 participants